Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables to print papers filtered by a tag + details button to display the full list #82

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thomas-lamiaux
Copy link
Contributor

@thomas-lamiaux thomas-lamiaux commented Jan 27, 2025

This is a small PR to enable us to print papers by categories on Learn/paper webpage

  • Makes it possible to print the recommended papers and papers filtered by a tag
  • Add a "More Papers" button to display the full list of papers
  • Make sure that the search works well with two categories + the details don't close back (Bugs)

PS: if you filter, then the search does search in the filtered papers so all works well

@thomas-lamiaux thomas-lamiaux marked this pull request as ready for review January 27, 2025 22:53
@mattam82
Copy link
Member

Let's try this on staging

@mattam82
Copy link
Member

Should be up in a minute at https://staging.rocq-prover.org (commit 42cd4a9)

@mattam82
Copy link
Member

I'm fine with it, probably we can improve the "More Papers" placement / visibility. @BastienSozeau ?

@mattam82
Copy link
Member

mattam82 commented Jan 28, 2025

Actually, if you search and hit enter your get a page with the results hidden under More Papers, that's broken to me.

@thomas-lamiaux
Copy link
Contributor Author

Right, the details button close when searching. So it filters correctly but do not work with <details> correctly

@thomas-lamiaux
Copy link
Contributor Author

I have written a small fix that checks if a query has been permformed and if so open the details, but it only works if the function is used once. If used several times, it bugs. I am sorry, I don't know how to do better.

@mattam82
Copy link
Member

I guess @BastienSozeau might know how to do better. I also think the "recommended papers" should disappear once a query has been done.

@thomas-lamiaux
Copy link
Contributor Author

If we print papers by tags, maybe we want on the right here, a search bar to search through all papers ?
image

I don't know if it should disappear or not. I would say no, if there is different section by topic.
To me the issue is mostly that the page reload but not at the level of the search section.

@mattam82
Copy link
Member

mattam82 commented Mar 4, 2025

I don't think it makes sense to keep the recommended papers when you enter a search, so I removed that section when a query (even an empty one) has been made. I think it's looking better now. Still have the common issue of jumping to #results in the page being hidden by the top bar... as in #88

@mattam82
Copy link
Member

mattam82 commented Mar 4, 2025

I'm deploying on staging for testing

@mattam82
Copy link
Member

mattam82 commented Mar 4, 2025

@thomas-lamiaux @BastienSozeau please have a look!

@thomas-lamiaux
Copy link
Contributor Author

I am not managing to check the last deployment on my phone, sth is wrong with the app. Could you post the url

@tabareau
Copy link
Contributor

tabareau commented Mar 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants